linux-kernel - Re: [PATCH v2] iio: core: move 'indio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3725f882accda683815f04c0eff0bb36c285fe62.camel@analog.com>
Date:   Tue, 7 Apr 2020 08:45:58 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     "Markus.Elfring@....de" <Markus.Elfring@....de>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
CC:     "jic23@...nel.org" <jic23@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] iio: core: move 'indio_dev->info' null check first

On Tue, 2020-04-07 at 10:20 +0200, Markus Elfring wrote:
> [External]
> 
> > Doesn't fix anything.
> 
> Would the change description be nicer without this sentence?
> 

That part is slightly debate-able.
I've had my fair-share of comments [during reviews], where others were
asking/saying "is this fixing anything? please state if this is fixing
anything".

So, over time I got the habit of mentioning 'Doesn't fix anything.' if the patch
doesn't fix anything. 

So, I'd leave it as-is [if that's possible].

> 
> > Just moves this …
> 
> I suggest to choose an imperative wording.
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=7e63420847ae5f1036e4f7c42f0b3282e73efbc2*n151__;Iw!!A3Ni8CS0y2Y!pMoqZILvWyu87fkNe16Sua0jMrZZK81oQOHENUhyTWZz9UrY4CisyKWSRCPFws0WTm50iQ$ 
> 

I admit, I didn't read that document too much in-depth.
And I probably won't, because I am lazy.

Personally, what I try to do, is guess the maintainer's/community's preferences
over time via interactions.
Things differ slightly from community to community.
Of course, there is some common ground across all communities, and I try to
apply that first.
Then, depending on the flexibility/past-comments from other sent-patches I try
to apply those on top [unless I forget; which I kinda do].

> Regards,
> Markus