linux-kernel - Re: [PATCH 2/3] iio: make use of iio_device_attach_kfifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Apr 2020 11:26:03 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>,
        devel@...verdev.osuosl.org, linux-iio@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Hartmut Knaack <knaack.h@....de>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Lorenzo Bianconi <lorenzo.bianconi83@...il.com>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Subject: Re: [PATCH 2/3] iio: make use of iio_device_attach_kfifo_buffer()
 where straightforward

How do you think about a patch subject like “iio: Increase use of iio_device_attach_kfifo_buffer()”?

> This change does that.

I suggest to improve also this commit message.

* Would you like to consider a wording like “Convert a specific function call
  combination to a better programming interface.”?

* Do you imagine any more software fine-tuning because of related
  collateral evolution?

Regards,
Markus