linux-kernel - Re: [PATCH v6 01/13] firmware: arm_scmi: Add receive buffer support for notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200407093629.GB28444@bogus>
Date:   Tue, 7 Apr 2020 10:36:29 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Cristian Marussi <cristian.marussi@....com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        lukasz.luba@....com, james.quinlan@...adcom.com,
        Jonathan.Cameron@...wei.com, Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v6 01/13] firmware: arm_scmi: Add receive buffer support
 for notifications

On Fri, Mar 27, 2020 at 02:34:26PM +0000, Cristian Marussi wrote:
> From: Sudeep Holla <sudeep.holla@....com>
>
> With all the plumbing in place, let's just add the separate dedicated
> receive buffers to handle notifications that can arrive asynchronously
> from the platform firmware to OS.
>
> Also add one check to see if the platform supports any receive channels
> before allocating the receive buffers: since those buffers are optionally
> supported though, the whole xfer initialization is also postponed to be
> able to check for their existence in advance.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> [Changed parameters in __scmi_xfer_info_init()]
> Signed-off-by: Cristian Marussi <cristian.marussi@....com>

[...]

> @@ -566,6 +568,16 @@ static int scmi_xfer_info_init(struct scmi_info *sinfo)
>  	return 0;
>  }
>
> +static int scmi_xfer_info_init(struct scmi_info *sinfo)
> +{
> +	int ret = __scmi_xfer_info_init(sinfo, &sinfo->tx_minfo);
> +
> +	if (!ret && idr_find(&sinfo->rx_idr, SCMI_PROTOCOL_BASE))

Theoretically, this could be bit tricky if we need to support platforms
without Rx channel for base protocol but may have Rx for some specific
protocols. But we have other problems too, so we can address that if
required in future.

Anyways, the first 4 patches are simple and quite independent from the
notification part. I will queue them as is and you can drop if you respin
the series.

I may need some time to go through the series completely and I am trying
to comment as I go through individual patches as I may get answers to
my own questions as I review.

--
Regards,
Sudeep