linux-kernel - Re: [PATCH v4 4/4] Input: adp5589: Fix possible memory leak of 'kpad'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5250434e-d83a-908e-ec7e-c84212e67e85@web.de>
Date:   Tue, 7 Apr 2020 15:40:07 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>,
        linux-input@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, lkp@...el.com,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v4 4/4] Input: adp5589: Fix possible memory leak of 'kpad'

> If 'adp5589_i2c_get_driver_data()' returns an error, the exit path should
> be to also free the 'kpad' object.

Wording alternative:
Release the kpad object also after a failed call of
the function “adp5589_i2c_get_driver_data”.


> This change fixes that.

Please replace this sentence by the tag “Fixes”
(because the exception handling was improved).

Regards,
Markus