linux-kernel - Re: [PATCH] scsi: aic7xxx: Remove null pointer checks before kfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200407155453.sosj4brsw6r7fnot@lenovo-laptop>
Date:   Tue, 7 Apr 2020 16:54:53 +0100
From:   Alex Dewar <alex.dewar@....co.uk>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Qiujun Huang <hqjagain@...il.com>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Hannes Reinecke <hare@...e.com>,
        "James E. J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH] scsi: aic7xxx: Remove null pointer checks before kfree()

Markus,

On Sun, Apr 05, 2020 at 10:02:47PM +0200, Markus Elfring wrote:
> > NULL check before kfree is unnecessary so remove it.
>
> I hope that you would like to take another update suggestion into account
> (besides a typo correction for your commit message).
> https://lore.kernel.org/patchwork/patch/1220189/
> https://lore.kernel.org/linux-scsi/20200403164712.49579-1-alex.dewar@gmx.co.uk/

I'm not sure I understand the relevance. Are you saying I should
reference this other patch?

>
> Do you find a previous update suggestion like “SCSI-aic7...: Delete unnecessary
> checks before the function call "kfree"” also interesting?
> https://lore.kernel.org/linux-scsi/54D3E057.9030600@users.sourceforge.net/
> https://lore.kernel.org/patchwork/patch/540593/
> https://lkml.org/lkml/2015/2/5/650
>

Thanks for the reference. I'll mention it in the commit if I do a v2.

Best,
Alex

> Regards,
> Markus