linux-kernel - Re: scsi: aic7xxx: Remove null pointer checks before kfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99c64c9f-0a9f-aafb-2e32-da7e026f9940@web.de>
Date:   Tue, 7 Apr 2020 18:32:19 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Alex Dewar <alex.dewar@....co.uk>, linux-scsi@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Hannes Reinecke <hare@...e.com>,
        "James E. J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Qiujun Huang <hqjagain@...il.com>
Subject: Re: scsi: aic7xxx: Remove null pointer checks before kfree()

>> I hope that you would like to take another update suggestion into account
>> (besides a typo correction for your commit message).
>> https://lore.kernel.org/patchwork/patch/1220189/
>> https://lore.kernel.org/linux-scsi/20200403164712.49579-1-alex.dewar@gmx.co.uk/
>
> I'm not sure I understand the relevance.

I pointed your patch out for another contributor.


> Are you saying I should reference this other patch?

I suggest to take another look at the development history for presented
patches according to a known source code search pattern.


> Thanks for the reference. I'll mention it in the commit if I do a v2.

I am curious under which circumstances the affected source files
will actually be improved in ways which were suggested a few times.

Regards,
Markus