linux-kernel - Re: [PATCH 25/28] mm: remove vmalloc_user_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200409060911.GA30101@lst.de>
Date:   Thu, 9 Apr 2020 08:09:11 +0200
From:   Christoph Hellwig <hch@....de>
To:     Hillf Danton <hdanton@...a.com>
Cc:     Christoph Hellwig <hch@....de>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 25/28] mm: remove vmalloc_user_node_flags

On Thu, Apr 09, 2020 at 12:06:45PM +0800, Hillf Danton wrote:
> > -	const gfp_t flags = __GFP_NOWARN | __GFP_ZERO;
> > +	const gfp_t gfp = __GFP_NOWARN | __GFP_ZERO;

> > +
> > +	return __vmalloc_node_range(size, align, VMALLOC_START, VMALLOC_END,
> > +			gfp | GFP_KERNEL | __GFP_RETRY_MAYFAIL, PAGE_KERNEL,
> 
> Dunno if __GFP_ZERO needs to be added to match the current 
> vmalloc_user_node_flags().

__GFP_ZERO is already included in "gfp".