linux-kernel - Re: [PATCH v1 03/28] i2c: owl: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Apr 2020 11:36:40 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Dejin Zheng <zhengdejin5@...il.com>
Cc:     thor.thayer@...ux.intel.com, krzysztof.adamski@...ia.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, f.fainelli@...il.com,
        nsekhar@...com, bgolaszewski@...libre.com,
        jarkko.nikula@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        mika.westerberg@...ux.intel.com, baruch@...s.co.il,
        wsa+renesas@...g-engineering.com, kgene@...nel.org,
        krzk@...nel.org, paul@...pouillou.net, vz@...ia.com,
        khilman@...libre.com, matthias.bgg@...il.com,
        gregory.clement@...tlin.com, rrichter@...vell.com,
        afaerber@...e.de, agross@...nel.org, bjorn.andersson@...aro.org,
        heiko@...ech.de, baohua@...nel.org, linus.walleij@...aro.org,
        mripard@...nel.org, wens@...e.org, ardb@...nel.org,
        michal.simek@...inx.com, gcherian@...vell.com, jun.nie@...aro.org,
        shawnguo@...nel.org, rayagonda.kokatanur@...adcom.com,
        lori.hikichi@...adcom.com, nishkadg.linux@...il.com,
        kstewart@...uxfoundation.org, allison@...utok.net,
        gregkh@...uxfoundation.org, tglx@...utronix.de,
        bigeasy@...utronix.de, info@...ux.net, hslester96@...il.com,
        narmstrong@...libre.com, martin.blumenstingl@...glemail.com,
        qii.wang@...iatek.com, drinkcat@...omium.org, hsinyi@...omium.org,
        fparent@...libre.com, opensource@...ayne.com, swinslow@...il.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 03/28] i2c: owl: convert to
 devm_platform_ioremap_resource

On Wed, Apr 08, 2020 at 12:37:16AM +0800, Dejin Zheng wrote:
> use devm_platform_ioremap_resource() to simplify code, which
> contains platform_get_resource and devm_ioremap_resource.
> 
> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com>

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Thanks,
Mani

> ---
>  drivers/i2c/busses/i2c-owl.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
> index b6b5a495118b..c9e7fcac12ae 100644
> --- a/drivers/i2c/busses/i2c-owl.c
> +++ b/drivers/i2c/busses/i2c-owl.c
> @@ -399,15 +399,13 @@ static int owl_i2c_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct owl_i2c_dev *i2c_dev;
> -	struct resource *res;
>  	int ret, irq;
>  
>  	i2c_dev = devm_kzalloc(dev, sizeof(*i2c_dev), GFP_KERNEL);
>  	if (!i2c_dev)
>  		return -ENOMEM;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	i2c_dev->base = devm_ioremap_resource(dev, res);
> +	i2c_dev->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(i2c_dev->base))
>  		return PTR_ERR(i2c_dev->base);
>  
> -- 
> 2.25.0
>