linux-kernel - Re: [PATCH v1 23/28] i2c: sirf: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4yiQed=kPpKJvHiGYJc0y0-qCmvV5+zYRKvBWJYVKrDog@mail.gmail.com>
Date:   Thu, 9 Apr 2020 12:02:58 +1200
From:   Barry Song <baohua@...nel.org>
To:     Dejin Zheng <zhengdejin5@...il.com>
Cc:     thor.thayer@...ux.intel.com, krzysztof.adamski@...ia.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, f.fainelli@...il.com,
        Sekhar Nori <nsekhar@...com>, bgolaszewski@...libre.com,
        jarkko.nikula@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        mika.westerberg@...ux.intel.com, Baruch Siach <baruch@...s.co.il>,
        wsa+renesas@...g-engineering.com, kgene@...nel.org,
        krzk@...nel.org, paul@...pouillou.net, vz@...ia.com,
        khilman@...libre.com, matthias.bgg@...il.com,
        gregory.clement@...tlin.com, rrichter@...vell.com,
        afaerber@...e.de, manivannan.sadhasivam@...aro.org,
        agross@...nel.org, bjorn.andersson@...aro.org, heiko@...ech.de,
        Linus Walleij <linus.walleij@...aro.org>, mripard@...nel.org,
        wens@...e.org, ardb@...nel.org,
        Michal Simek <michal.simek@...inx.com>, gcherian@...vell.com,
        jun.nie@...aro.org, shawnguo@...nel.org,
        rayagonda.kokatanur@...adcom.com, lori.hikichi@...adcom.com,
        nishkadg.linux@...il.com, kstewart@...uxfoundation.org,
        allison@...utok.net,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>, bigeasy@...utronix.de,
        info@...ux.net, hslester96@...il.com, narmstrong@...libre.com,
        martin.blumenstingl@...glemail.com, qii.wang@...iatek.com,
        drinkcat@...omium.org, hsinyi@...omium.org, fparent@...libre.com,
        opensource@...ayne.com, swinslow@...il.com,
        linux-i2c@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 23/28] i2c: sirf: convert to devm_platform_ioremap_resource

Dejin Zheng <zhengdejin5@...il.com> 于2020年4月8日周三 上午4:39写道：
>
> use devm_platform_ioremap_resource() to simplify code, which
> contains platform_get_resource and devm_ioremap_resource.
>
> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com>

Reviewed-by: Barry Song <baohua@...nel.org>

> ---
>  drivers/i2c/busses/i2c-sirf.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-sirf.c b/drivers/i2c/busses/i2c-sirf.c
> index fb7a046b3226..269a71b0ee7f 100644
> --- a/drivers/i2c/busses/i2c-sirf.c
> +++ b/drivers/i2c/busses/i2c-sirf.c
> @@ -272,7 +272,6 @@ static int i2c_sirfsoc_probe(struct platform_device *pdev)
>  {
>         struct sirfsoc_i2c *siic;
>         struct i2c_adapter *adap;
> -       struct resource *mem_res;
>         struct clk *clk;
>         int bitrate;
>         int ctrl_speed;
> @@ -310,8 +309,7 @@ static int i2c_sirfsoc_probe(struct platform_device *pdev)
>         adap = &siic->adapter;
>         adap->class = I2C_CLASS_DEPRECATED;
>
> -       mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       siic->base = devm_ioremap_resource(&pdev->dev, mem_res);
> +       siic->base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(siic->base)) {
>                 err = PTR_ERR(siic->base);
>                 goto out;
> --
> 2.25.0
>