linux-kernel - Re: [Cocci] Coccinelle rule for CVE-2019-18683

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a562397-ba60-8979-1453-b88153722803@linux.com>
Date:   Thu, 9 Apr 2020 21:11:44 +0300
From:   Alexander Popov <alex.popov@...ux.com>
To:     Markus Elfring <Markus.Elfring@....de>, cocci@...teme.lip6.fr,
        kernel-hardening@...ts.openwall.com
Cc:     linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Hans Verkuil <hverkuil@...all.nl>,
        Jann Horn <jannh@...gle.com>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Kees Cook <keescook@...omium.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>
Subject: Re: [Cocci] Coccinelle rule for CVE-2019-18683

Markus, thanks for your remarks!

On 09.04.2020 11:41, Markus Elfring wrote:
> * The source code search pattern can be too generic.
>   How do you think about to consider additional constraints
>   for safer data control flow analysis?

Could you please elaborate on that?

I used 'exists' keyword to find at least one branch that has
mutex_unlock+kthread_stop+mutex_lock chain.

> * Other operation modes might become helpful.

Thanks! I added 'context' mode, it's very good for this purpose.

Best regards,
Alexander