linux-kernel - Re: [Cocci] Coccinelle rule for CVE-2019-18683

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <840858a4-2440-3fbd-297a-db2dacbcf24c@web.de>
Date:   Fri, 10 Apr 2020 15:16:57 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Alexander Popov <alex.popov@...ux.com>, cocci@...teme.lip6.fr,
        kernel-hardening@...ts.openwall.com
Cc:     linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Hans Verkuil <hverkuil@...all.nl>,
        Jann Horn <jannh@...gle.com>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Kees Cook <keescook@...omium.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>
Subject: Re: [Cocci] Coccinelle rule for CVE-2019-18683

>> * The source code search pattern can be too generic.
>>   How do you think about to consider additional constraints
>>   for safer data control flow analysis?
>
> Could you please elaborate on that?

Julia Lawall chose to mention the design possibility “put when
!= mutex_lock(E) after the ...”.
https://systeme.lip6.fr/pipermail/cocci/2020-April/007107.html
https://lore.kernel.org/cocci/alpine.DEB.2.21.2004091248190.2403@hadrien/


> I used 'exists' keyword to find at least one branch that has
> mutex_unlock+kthread_stop+mutex_lock chain.

Are you informed about development challenges for data flow analysis
(or even escape analysis according to computer science)?

How many experiences can be reused from other known approaches?

Regards,
Markus