linux-kernel - Re: [PATCH v3 00/24] firmware: xilinx: Add xilinx specific sysfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59e1c4e7-176e-73d0-83c1-55c84ba5ad85@xilinx.com>
Date:   Thu, 9 Apr 2020 12:17:23 -0700
From:   Jolly Shah <jolly.shah@...inx.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Jolly Shah <jolly.shah@...inx.com>
Cc:     ard.biesheuvel@...aro.org, mingo@...nel.org,
        matt@...eblueprint.co.uk, sudeep.holla@....com,
        hkallweit1@...il.com, keescook@...omium.org,
        dmitry.torokhov@...il.com, michal.simek@...inx.com,
        rajanv@...inx.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 00/24] firmware: xilinx: Add xilinx specific sysfs
 interface

Hi Greg,
Thanks for the review.

 > ------Original Message------
 > From: 'Greg Kh' <gregkh@...uxfoundation.org>
 > Sent:  Wednesday, March 18, 2020 4:54AM
 > To: Jolly Shah <jolly.shah@...inx.com>
 > Cc: Ard.biesheuvel@...aro.org <ard.biesheuvel@...aro.org>, 
Mingo@...nel.org <mingo@...nel.org>, Matt@...eblueprint.co.uk 
<matt@...eblueprint.co.uk>, Sudeep.holla@....com <sudeep.holla@....com>, 
Hkallweit1@...il.com <hkallweit1@...il.com>, Keescook@...omium.org 
<keescook@...omium.org>, Dmitry.torokhov@...il.com 
<dmitry.torokhov@...il.com>, Michal Simek <michal.simek@...inx.com>, 
Rajan Vaja <rajanv@...inx.com>, Linux-arm-kernel@...ts.infradead.org 
<linux-arm-kernel@...ts.infradead.org>, Linux-kernel@...r.kernel.org 
<linux-kernel@...r.kernel.org>
 > Subject: Re: [PATCH v3 00/24] firmware: xilinx: Add xilinx specific 
sysfs interface
 >
> On Fri, Mar 06, 2020 at 03:47:08PM -0800, Jolly Shah wrote:
>> This patch series adds xilinx specific sysfs interface for below
>> purposes:
>> - Register access
>> - Set shutdown scope
>> - Set boot health status bit
>>
>> Also this patch series removes eemi ops and adds API
>> corresponding to each eemi ops.
> 
> I've applied the first 19 patches here, they looked good, thanks for
> doing that work, makes things a lot more "obvious" as to what is going
> on here.
> 
> The rest, please see my review comments and redo.
> 

Submitted v4 patchset. It addresses your review comments. Also took care 
of compilation issues observed for first 19 patches.
Please review.

Thanks,
Jolly Shah


> thanks,
> 
> greg k-h
>