linux-kernel - Re: [patch 0/3] x86/kvm: Basic split lock #AC handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Apr 2020 12:02:43 -0700
From:   Sean Christopherson <sean.j.christopherson@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        "Kenneth R. Crudup" <kenny@...ix.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Xiaoyao Li <xiaoyao.li@...el.com>,
        Nadav Amit <namit@...are.com>,
        Thomas Hellstrom <thellstrom@...are.com>,
        Tony Luck <tony.luck@...el.com>
Subject: Re: [patch 0/3] x86/kvm: Basic split lock #AC handling

On Fri, Apr 10, 2020 at 01:53:59PM +0200, Thomas Gleixner wrote:
> This is a reworked version of the patches posted by Sean:
> 
>  https://lore.kernel.org/r/20200402155554.27705-1-sean.j.christopherson@intel.com
> 
> The changes vs. this are:
> 
>     1) Use a separate function for guest split lock handling
> 
>     2) Force SIGBUS when SLD mode fatal

Not that it matters as the code is correct, but I think you meant
"when SLD mode off" here.

>     3) Rename the misnomed helper function which decides whether
>        #AC is injected into the guest or not and move the feature
>        check and the comments into that helper.

Thanks a bunch for helping push this along!