linux-kernel - Re: [PATCH 4/9] dt-bindings: power: supply: Add device-tree binding for Summit SMB3xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c4ab1ce-1947-ab38-3f8c-9055406428e4@gmail.com>
Date:   Fri, 10 Apr 2020 22:02:35 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Rob Herring <robh@...nel.org>, David Heidelberg <david@...t.cz>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Jonghwa Lee <jonghwa3.lee@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Myungjoo Ham <myungjoo.ham@...sung.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        John Stultz <john.stultz@...aro.org>,
        Vinay Simha BN <simhavcs@...il.com>,
        mika.westerberg@...ux.intel.com, ramakrishna.pallala@...el.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 4/9] dt-bindings: power: supply: Add device-tree binding
 for Summit SMB3xx

10.04.2020 19:49, Rob Herring пишет:
...
>> +  summit,max-chg-curr:
>> +    description: Maximum current for charging (in uA)
>> +    allOf:
>> +      - $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> +  summit,max-chg-volt:
>> +    description: Maximum voltage for charging (in uV)
>> +    allOf:
>> +      - $ref: /schemas/types.yaml#/definitions/uint32
>> +    minimum: 3500000
>> +    maximum: 4500000
>> +
>> +  summit,pre-chg-curr:
>> +    description: Pre-charging current for charging (in uA)
>> +    allOf:
>> +      - $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> +  summit,term-curr:
>> +    description: Charging cycle termination current (in uA)
>> +    allOf:
>> +      - $ref: /schemas/types.yaml#/definitions/uint32
...
> These are all properties of the battery attached and we have standard 
> properties for some/all of these.

Looks like only four properties seem to be matching the properties of
the battery.txt binding.

Are you suggesting that these matching properties should be renamed
after the properties in battery.txt?

> Also, any property with units should have a unit suffix as defined in 
> property-units.txt. And with that, you don't need to define the type.

Indeed, thank you for the suggestion.