linux-kernel - Re: [PATCH] usb: phy: jz4770: Add a missing '\n' in a log message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d42889be3ae1c77c6ca33d9dbd87ab46c749cfff.camel@perches.com>
Date:   Sat, 11 Apr 2020 08:46:49 -0700
From:   Joe Perches <joe@...ches.com>
To:     Paul Cercueil <paul@...pouillou.net>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     balbi@...nel.org, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] usb: phy: jz4770: Add a missing '\n' in a log message

On Sat, 2020-04-11 at 15:13 +0200, Paul Cercueil wrote:
> Hi Christophe,
> 
> Le sam. 11 avril 2020 à 8:38, Christophe JAILLET 
> <christophe.jaillet@...adoo.fr> a écrit :
> > Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
> 
> Is that so?
> From what I could see these macros add the \n themselves if needed.

Not so.

> So the \n were omitted on purpose.

Just a trivial oversight really.

AFAIK: It's an issue _only_ in two cases:

p another process emits a printk with KERN_CONT (or pr_cont)
  that might extend this message in the log on the same line.

o this message wukk not be emitted into the log until another
  message arrives