linux-kernel - Re: [PATCH] usb: phy: jz4770: Add a missing '\n' in a log message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200414093118.GD1163@kadam>
Date:   Tue, 14 Apr 2020 12:31:18 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        balbi@...nel.org, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] usb: phy: jz4770: Add a missing '\n' in a log message

On Sat, Apr 11, 2020 at 03:13:47PM +0200, Paul Cercueil wrote:
> Hi Christophe,
> 
> Le sam. 11 avril 2020 à 8:38, Christophe JAILLET
> <christophe.jaillet@...adoo.fr> a écrit :
> > Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
> 
> Is that so?
> 
> From what I could see these macros add the \n themselves if needed. So the
> \n were omitted on purpose.
> 

Do a "make drivers/usb/phy/phy-jz4770.i" and look at the string.  The
patch is correct.

regards,
dan carpenter