linux-kernel - Re: [PATCH RESEND] MAINTAINERS: rectify EDAC-SIFIVE entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Apr 2020 10:15:56 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Christoph Hellwig <hch@....de>,
        Yash Shah <yash.shah@...ive.com>, linux-edac@...r.kernel.org,
        Sebastian Duda <sebastian.duda@....de>,
        Joe Perches <joe@...ches.com>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] MAINTAINERS: rectify EDAC-SIFIVE entry

On Mon, Apr 13, 2020 at 09:34:47AM +0200, Lukas Bulwahn wrote:
> Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved
> arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c
> and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.
> 
> Since then, ./scripts/get_maintainer.pl --self-test complains:
> 
>   warning: no file matches F: drivers/soc/sifive_l2_cache.c
> 
> Rectify the EDAC-SIFIVE entry in MAINTAINERS now.
> 
> Co-developed-by: Sebastian Duda <sebastian.duda@....de>
> Signed-off-by: Sebastian Duda <sebastian.duda@....de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
> Paul, please pick this patch.
> 
> v1: https://lore.kernel.org/lkml/20200304144045.15060-1-lukas.bulwahn@gmail.com/
>   - was not picked up.
> 
> v1-resend: applies on v5.7-rc1
> 
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e64e5db31497..e28676766b26 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6172,7 +6172,7 @@ M:	Yash Shah <yash.shah@...ive.com>
>  L:	linux-edac@...r.kernel.org
>  S:	Supported
>  F:	drivers/edac/sifive_edac.c
> -F:	drivers/soc/sifive_l2_cache.c
> +F:	drivers/soc/sifive/sifive_l2_cache.c

Looking at that a bit - I think the right thing to do is to remove that
sifive_l2_cache.c file from the EDAC-SIFIVE file pattern because the
edac driver is simply using the L2 thing to register on its notifier
chain, i.e., using an external facility, like all the drivers do. And the
l2_cache thing is not part of the edac driver.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette