linux-kernel - Re: [PATCH v2] MAINTAINERS: place sifive_l2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Apr 2020 14:02:25 +0200 (CEST)
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Christoph Hellwig <hch@....de>, Borislav Petkov <bp@...e.de>,
        Yash Shah <yash.shah@...ive.com>, linux-edac@...r.kernel.org,
        Sebastian Duda <sebastian.duda@....de>,
        Joe Perches <joe@...ches.com>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] MAINTAINERS: place sifive_l2_cache.c only in SIFIVE
 DRIVERS



On Mon, 13 Apr 2020, Lukas Bulwahn wrote:

> Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved
> arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c
> and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.
> 
> Since then, ./scripts/get_maintainer.pl --self-test complains:
> 
>   warning: no file matches F: drivers/soc/sifive_l2_cache.c
> 
> Boris suggested that sifive_l2_cache.c is considered part of the SIFIVE
> DRIVERS, not part of EDAC-SIFIVE. So, we can simply drop this entry, and
> by the sifive keyword pattern in SIFIVE PATTERNS, it is automatically part
> of the SIFIVE DRIVERS.
> 
> Suggested-by: Borislav Petkov <bp@...en8.de>
> Co-developed-by: Sebastian Duda <sebastian.duda@....de>
> Signed-off-by: Sebastian Duda <sebastian.duda@....de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
> Paul, please pick this patch.
> 
> v1: https://lore.kernel.org/lkml/20200304144045.15060-1-lukas.bulwahn@gmail.com/
>   - was not picked up.
> 
> v1-resend: https://lore.kernel.org/lkml/20200413073447.9284-1-lukas.bulwahn@gmail.com/
> 
> v2: reworked based on Boris comment; applies on v5.7-rc1
> 
> 
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e64e5db31497..e28676766b26 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6172,7 +6172,7 @@ M:	Yash Shah <yash.shah@...ive.com>
>  L:	linux-edac@...r.kernel.org
>  S:	Supported
>  F:	drivers/edac/sifive_edac.c
> -F:	drivers/soc/sifive_l2_cache.c
> +F:	drivers/soc/sifive/sifive_l2_cache.c
>  
>  EDAC-SKYLAKE
>  M:	Tony Luck <tony.luck@...el.com>
> -- 
> 2.17.1
> 
> 

Please ignore this patch. I accidently sent this patch out too quickly.

Please consider and pick this PATCH v3 instead:

https://lore.kernel.org/lkml/20200413115255.7100-1-lukas.bulwahn@gmail.com/


Lukas