lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Apr 2020 16:35:09 +0200 From: Enric Balletbo i Serra <enric.balletbo@...labora.com> To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, bleung@...omium.org, groeck@...omium.org, andy.shevchenko@...il.com, Jonathan.Cameron@...wei.com Cc: gwendal@...omium.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] platform/chrome: cros_ec_sensorhub: Add missing '\n' in log messages Hi Christophe, Thank you for your patch. On 11/4/20 16:58, Christophe JAILLET wrote: > Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'. > > Fixes: 145d59baff59 ("platform/chrome: cros_ec_sensorhub: Add FIFO support") > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > --- Applied as a fix for 5.7 > drivers/platform/chrome/cros_ec_sensorhub_ring.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_sensorhub_ring.c b/drivers/platform/chrome/cros_ec_sensorhub_ring.c > index 230e6cf3da2f..c51af569708f 100644 > --- a/drivers/platform/chrome/cros_ec_sensorhub_ring.c > +++ b/drivers/platform/chrome/cros_ec_sensorhub_ring.c > @@ -820,7 +820,7 @@ static void cros_ec_sensorhub_ring_handler(struct cros_ec_sensorhub *sensorhub) > if (fifo_info->count > sensorhub->fifo_size || > fifo_info->size != sensorhub->fifo_size) { > dev_warn(sensorhub->dev, > - "Mismatch EC data: count %d, size %d - expected %d", > + "Mismatch EC data: count %d, size %d - expected %d\n", > fifo_info->count, fifo_info->size, > sensorhub->fifo_size); > goto error; > @@ -851,14 +851,14 @@ static void cros_ec_sensorhub_ring_handler(struct cros_ec_sensorhub *sensorhub) > } > if (number_data > fifo_info->count - i) { > dev_warn(sensorhub->dev, > - "Invalid EC data: too many entry received: %d, expected %d", > + "Invalid EC data: too many entry received: %d, expected %d\n", > number_data, fifo_info->count - i); > break; > } > if (out + number_data > > sensorhub->ring + fifo_info->count) { > dev_warn(sensorhub->dev, > - "Too many samples: %d (%zd data) to %d entries for expected %d entries", > + "Too many samples: %d (%zd data) to %d entries for expected %d entries\n", > i, out - sensorhub->ring, i + number_data, > fifo_info->count); > break; >
Powered by blists - more mailing lists