linux-kernel - Re: [PATCH v5 2/3] mmc: host: sdhci: Implement the request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202004131201.LSx92dnS%lkp@intel.com>
Date:   Mon, 13 Apr 2020 12:40:34 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Baolin Wang <baolin.wang7@...il.com>
Cc:     kbuild-all@...ts.01.org, ulf.hansson@...aro.org,
        adrian.hunter@...el.com, arnd@...db.de, baolin.wang7@...il.com,
        orsonzhai@...il.com, zhang.lyra@...il.com,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/3] mmc: host: sdhci: Implement the request_atomic()
 API

Hi Baolin,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.7-rc1 next-20200412]
[cannot apply to arm-soc/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Baolin-Wang/Introduce-the-request_atomic-for-the-host/20200413-105346
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8f3d9f354286745c751374f5f1fcafee6b3f3136
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/mmc/host/sdhci.c: In function 'sdhci_request_atomic':
>> drivers/mmc/host/sdhci.c:2076:6: error: implicit declaration of function 'sdhci_present_error' [-Werror=implicit-function-declaration]
    2076 |  if (sdhci_present_error(host, mrq->cmd, true)) {
         |      ^~~~~~~~~~~~~~~~~~~
>> drivers/mmc/host/sdhci.c:2081:8: error: implicit declaration of function 'sdhci_manual_cmd23'; did you mean 'sdhci_auto_cmd12'? [-Werror=implicit-function-declaration]
    2081 |  cmd = sdhci_manual_cmd23(host, mrq) ? mrq->sbc : mrq->cmd;
         |        ^~~~~~~~~~~~~~~~~~
         |        sdhci_auto_cmd12
>> drivers/mmc/host/sdhci.c:2090:6: error: invalid use of void expression
    2090 |  if (!sdhci_send_command(host, cmd))
         |      ^
   cc1: some warnings being treated as errors

vim +/sdhci_present_error +2076 drivers/mmc/host/sdhci.c

  2066	
  2067	int sdhci_request_atomic(struct mmc_host *mmc, struct mmc_request *mrq)
  2068	{
  2069		struct sdhci_host *host = mmc_priv(mmc);
  2070		struct mmc_command *cmd;
  2071		unsigned long flags;
  2072		int ret = 0;
  2073	
  2074		spin_lock_irqsave(&host->lock, flags);
  2075	
> 2076		if (sdhci_present_error(host, mrq->cmd, true)) {
  2077			sdhci_finish_mrq(host, mrq);
  2078			goto out_finish;
  2079		}
  2080	
> 2081		cmd = sdhci_manual_cmd23(host, mrq) ? mrq->sbc : mrq->cmd;
  2082	
  2083		/*
  2084		 * The HSQ may send a command in interrupt context without polling
  2085		 * the busy signaling, which means we should return BUSY if controller
  2086		 * has not released inhibit bits to allow HSQ trying to send request
  2087		 * again in non-atomic context. So we should not finish this request
  2088		 * here.
  2089		 */
> 2090		if (!sdhci_send_command(host, cmd))
  2091			ret = -EBUSY;
  2092		else
  2093			sdhci_led_activate(host);
  2094	
  2095	out_finish:
  2096		spin_unlock_irqrestore(&host->lock, flags);
  2097		return ret;
  2098	}
  2099	EXPORT_SYMBOL_GPL(sdhci_request_atomic);
  2100	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (63433 bytes)