linux-kernel - Re: [PATCH] coresight: cti: make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200413175837.GE28804@xps15>
Date:   Mon, 13 Apr 2020 11:58:37 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     suzuki.poulose@....com, mike.leach@...aro.org,
        alexander.shishkin@...ux.intel.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] coresight: cti: make some symbols static

On Mon, Apr 13, 2020 at 04:22:24PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
> 
> drivers/hwtracing/coresight/coresight-cti.c:22:1: warning: symbol
> 'ect_net' was not declared. Should it be static?
> drivers/hwtracing/coresight/coresight-cti.c:625:32: warning: symbol
> 'cti_ops_ect' was not declared. Should it be static?
> drivers/hwtracing/coresight/coresight-cti.c:630:28: warning: symbol
> 'cti_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/hwtracing/coresight/coresight-cti.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c
> index 9e262f5a85e3..7fc1fc8d7738 100644
> --- a/drivers/hwtracing/coresight/coresight-cti.c
> +++ b/drivers/hwtracing/coresight/coresight-cti.c
> @@ -19,7 +19,7 @@
>   */
>  
>  /* net of CTI devices connected via CTM */
> -LIST_HEAD(ect_net);
> +static LIST_HEAD(ect_net);
>  
>  /* protect the list */
>  static DEFINE_MUTEX(ect_mutex);
> @@ -622,12 +622,12 @@ int cti_disable(struct coresight_device *csdev)
>  	return cti_disable_hw(drvdata);
>  }
>  
> -const struct coresight_ops_ect cti_ops_ect = {
> +static const struct coresight_ops_ect cti_ops_ect = {
>  	.enable = cti_enable,
>  	.disable = cti_disable,
>  };
>  
> -const struct coresight_ops cti_ops = {
> +static const struct coresight_ops cti_ops = {
>  	.ect_ops = &cti_ops_ect,
>  };

Applied - thanks,
Mathieu

>  
> -- 
> 2.21.1
>