linux-kernel - Re: [PATCH] coresight: etb10: make coresight_etb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200413175915.GF28804@xps15>
Date:   Mon, 13 Apr 2020 11:59:15 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     suzuki.poulose@....com, mike.leach@...aro.org,
        alexander.shishkin@...ux.intel.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] coresight: etb10: make coresight_etb_groups static

On Mon, Apr 13, 2020 at 04:22:37PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
> 
> drivers/hwtracing/coresight/coresight-etb10.c:720:30: warning: symbol
> 'coresight_etb_groups' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/hwtracing/coresight/coresight-etb10.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
> index 3810290e6d07..03e3f2590191 100644
> --- a/drivers/hwtracing/coresight/coresight-etb10.c
> +++ b/drivers/hwtracing/coresight/coresight-etb10.c
> @@ -717,7 +717,7 @@ static const struct attribute_group coresight_etb_mgmt_group = {
>  	.name = "mgmt",
>  };
>  
> -const struct attribute_group *coresight_etb_groups[] = {
> +static const struct attribute_group *coresight_etb_groups[] = {
>  	&coresight_etb_group,
>  	&coresight_etb_mgmt_group,
>  	NULL,

Applied - thanks,
Mathieu

> -- 
> 2.21.1
>