linux-kernel - Re: [PATCH] scsi: sg: fix memory leak in sg_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b5551e6-46e2-9def-8ab6-ec5ba252c5ea@web.de>
Date:   Mon, 13 Apr 2020 21:35:43 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Li Bin <huawei.libin@...wei.com>, linux-scsi@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Doug Gilbert <dgilbert@...erlog.com>,
        "James E. J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Xie XiuQi <xiexiuqi@...wei.com>
Subject: Re: [PATCH] scsi: sg: fix memory leak in sg_build_indirect

> Fix a memory leak when there have failed, that we should free the pages
> under the condition rem_sz > 0.

I suggest to improve the change description.

* Please use an imperative wording.

* Will the tag “Fixes” become relevant?

Regards,
Markus