linux-kernel - Re: [PATCH] scsi: sg: fix memory leak in sg_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0162f996-eb48-fda5-8355-1c9bc1162177@interlog.com>
Date:   Mon, 13 Apr 2020 21:39:04 -0400
From:   Douglas Gilbert <dgilbert@...erlog.com>
To:     Markus Elfring <Markus.Elfring@....de>,
        Li Bin <huawei.libin@...wei.com>, linux-scsi@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        "James E. J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Xie XiuQi <xiexiuqi@...wei.com>
Subject: Re: [PATCH] scsi: sg: fix memory leak in sg_build_indirect

On 2020-04-13 3:35 p.m., Markus Elfring wrote:
>> Fix a memory leak when there have failed, that we should free the pages
>> under the condition rem_sz > 0.
> 
> I suggest to improve the change description.
> 
> * Please use an imperative wording.

nominative, vocative, accusative, genitive ...

I have made some comment suggestions in response to the original posts
from the author.

> * Will the tag “Fixes” become relevant?

Yes, both patches from the author are fixes. These leaks would typically
appear on a system under resource pressure (specifically low memory) and
would tend to make the situation worse.

Doug Gilbert