linux-kernel - Re: [PATCH v1] i2c: img-scb: remove duplicate dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200414162002.GX34613@smile.fi.intel.com>
Date:   Tue, 14 Apr 2020 19:20:02 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Dejin Zheng <zhengdejin5@...il.com>
Cc:     linus.walleij@...aro.org, patrice.chotard@...com, info@...ux.net,
        allison@...utok.net, nehal-bakulchandra.shah@....com,
        tglx@...utronix.de, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] i2c: img-scb: remove duplicate dev_err()

On Tue, Apr 14, 2020 at 11:50:47PM +0800, Dejin Zheng wrote:
> On Tue, Apr 14, 2020 at 05:38:37PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 14, 2020 at 10:26:50PM +0800, Dejin Zheng wrote:
> > > it will print an error message by itself when platform_get_irq()
> > > goes wrong. so don't need dev_err() in here again.
> > 
> > In the future, please use something like this
> > 	scripts/get_maintainer.pl --git --git-min-percent=67
> > when retrieve Cc list for the mail.
> >
> Andy, Thank you for reminding me again, if I used it, There are only two
> email addresses. 
> 
> scripts/get_maintainer.pl --git --git-min-percent=67 v1-0001-i2c-img-scb-remove-duplicate-dev_err.patch
> linux-i2c@...r.kernel.org (open list:I2C SUBSYSTEM HOST DRIVERS)
> linux-kernel@...r.kernel.org (open list)

Nice, you found a bug in MAINTAINERS database.

> > FWIW,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> >
> Thanks very much for your review.

I recommend to resend a new version with those mailings lists followed by
Wolfram included in the Cc list. Don't forget to add my tag in the commit
message and bump the version.

-- 
With Best Regards,
Andy Shevchenko