linux-kernel - Re: [PATCH] mm/ksm: Fix a null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <740ca6b2-d3c9-02a2-9d81-c212bf9772e2@web.de>
Date:   Tue, 14 Apr 2020 09:14:17 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Muchun Song <songmuchun@...edance.com>,
        Xiongchun duan <duanxiongchun@...edance.com>,
        linux-mm@...ck.org
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm/ksm: Fix a null pointer dereference

> The find_mergeable_vma can return NULL. In this case, it leads
> to crash when we access vma->vm_mm(which's offset is 0x40) in

I suggest to improve the commit message.

* Wording alternative:
  to a crash when we access vma->vm_mm (its offset is 0x40) in

* Can a function name be nicer than the information “at 0000000000000040”
  in the patch subject?

* Would you like to add the tag “Fixes” to the change description?

Regards,
Markus