linux-kernel - Re: [External] Re: [PATCH] mm/ksm: Fix a null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMZfGtWEGuGCP1hNK7o82B_R_JQHFt7hfn+mRP+pOfUF7ygmZA@mail.gmail.com>
Date:   Tue, 14 Apr 2020 15:19:17 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Xiongchun duan <duanxiongchun@...edance.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [External] Re: [PATCH] mm/ksm: Fix a null pointer dereference

On Tue, Apr 14, 2020 at 3:14 PM Markus Elfring <Markus.Elfring@....de> wrote:
>
> > The find_mergeable_vma can return NULL. In this case, it leads
> > to crash when we access vma->vm_mm(which's offset is 0x40) in
>
> I suggest to improve the commit message.
>
> * Wording alternative:
>   to a crash when we access vma->vm_mm (its offset is 0x40) in
>
> * Can a function name be nicer than the information “at 0000000000000040”
>   in the patch subject?
>
> * Would you like to add the tag “Fixes” to the change description?
>

Thanks for your suggestion. I will send a v2 patch later.


-- 
Yours,
Muchun