linux-kernel - Re: [PATCH 07/23] floppy: use symbolic register names in the sparc64 port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcaddeb1-7017-9ac7-fd76-ebd1146b4293@linux.com>
Date:   Tue, 14 Apr 2020 12:20:57 +0300
From:   Denis Efremov <efremov@...ux.com>
To:     Willy Tarreau <w@....eu>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 07/23] floppy: use symbolic register names in the sparc64
 port

Hi,

On 3/31/20 12:40 PM, Willy Tarreau wrote:
-		printk("floppy: Asked to read unknown port %lx\n", port);
> +		printk("floppy: Asked to read unknown port %lx\n", reg);

> -		printk("floppy: Asked to write to unknown port %lx\n", port);
> +		printk("floppy: Asked to write to unknown port %lx\n", reg);

sparc64 showed a couple of warnings in printks (I will send fixes)
./arch/sparc/include/asm/floppy_64.h: In function ‘sun_82077_fd_inb’:
./arch/sparc/include/asm/floppy_64.h:106:48: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘unsigned int’ [-Wformat=]
  106 |   printk("floppy: Asked to read unknown port %lx\n", reg);
      |                                              ~~^     ~~~
      |                                                |     |
      |                                                |     unsigned int
      |                                                long unsigned int
      |                                              %x
./arch/sparc/include/asm/floppy_64.h: In function ‘sun_82077_fd_outb’:
./arch/sparc/include/asm/floppy_64.h:125:52: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘unsigned int’ [-Wformat=]
  125 |   printk("floppy: Asked to write to unknown port %lx\n", reg);
      |                                                  ~~^     ~~~
      |                                                    |     |
      |                                                    |     unsigned int
      |                                                    long unsigned int
      |                                                  %x

A couple of new warnings.