linux-kernel - drivers/gpu/drm/bridge/display-connector.c:34:48: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 14 Apr 2020 22:17:42 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Maxime Ripard <mripard@...nel.org>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Sebastian Reichel <sebastian.reichel@...labora.com>
Subject: drivers/gpu/drm/bridge/display-connector.c:34:48: warning: Clarify
 calculation precedence for '&' and '?'. [clarifyCalculation]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8f3d9f354286745c751374f5f1fcafee6b3f3136
commit: 0c275c30176b2e7871c6ac5fb0ed548f81e0fa27 drm/bridge: Add bridge driver for display connectors
date:   7 weeks ago

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>


cppcheck warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/ttm/ttm_bo.c:409:9: warning: Identical condition and return expression 'r', return value is always 0 [identicalConditionAfterEarlyExit]
    return r;
           ^
   drivers/gpu/drm/ttm/ttm_bo.c:396:6: note: If condition 'r' is true, the function will return/exit
    if (r)
        ^
   drivers/gpu/drm/ttm/ttm_bo.c:409:9: note: Returning identical expression 'r'
    return r;
           ^
   drivers/gpu/drm/ttm/ttm_bo.c:100:9: warning: The scope of the variable 'ret' can be reduced. [variableScope]
    int i, ret, mem_type;
           ^
   drivers/gpu/drm/ttm/ttm_bo.c:572:6: warning: The scope of the variable 'ret' can be reduced. [variableScope]
    int ret;
        ^
   drivers/gpu/drm/ttm/ttm_bo.c:913:6: warning: The scope of the variable 'ret' can be reduced. [variableScope]
    int ret;
        ^
   drivers/gpu/drm/ttm/ttm_bo.c:1241:7: warning: The scope of the variable 'locked' can be reduced. [variableScope]
    bool locked;
         ^
   drivers/gpu/drm/ttm/ttm_bo.c:1623:31: warning: The scope of the variable 'man' can be reduced. [variableScope]
    struct ttm_mem_type_manager *man;
                                 ^
   drivers/gpu/drm/ttm/ttm_bo.c:1822:28: warning: Local variable 'ctx' shadows outer argument [shadowArgument]
     struct ttm_operation_ctx ctx = { false, false };
                              ^
   drivers/gpu/drm/ttm/ttm_bo.c:1775:74: note: Shadowed declaration
   int ttm_bo_swapout(struct ttm_bo_global *glob, struct ttm_operation_ctx *ctx)
                                                                            ^
   drivers/gpu/drm/ttm/ttm_bo.c:1822:28: note: Shadow variable
     struct ttm_operation_ctx ctx = { false, false };
                              ^
--
>> drivers/gpu/drm/drm_bridge.c:1006:7: warning: Local variable 'ret' shadows outer variable [shadowVariable]
     int ret;
         ^
   drivers/gpu/drm/drm_bridge.c:994:6: note: Shadowed declaration
    int ret;
        ^
   drivers/gpu/drm/drm_bridge.c:1006:7: note: Shadow variable
     int ret;
         ^
--
>> drivers/gpu/drm/bridge/display-connector.c:34:48: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
    return flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR ? 0 : -EINVAL;
                                                  ^
--
>> drivers/gpu/drm/tidss/tidss_scale_coefs.c:159:15: warning: struct member 'Anonymous0::name' is never used. [unusedStructMember]
     const char *name;
                 ^
--
   drivers/gpu/drm/tidss/tidss_dispc.c:1929:6: warning: The scope of the variable 'ret' can be reduced. [variableScope]
    int ret;
        ^
>> drivers/gpu/drm/tidss/tidss_dispc.c:2312:11: warning: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned]
      v |= 1 << 31;
             ^

vim +34 drivers/gpu/drm/bridge/display-connector.c

    30	
    31	static int display_connector_attach(struct drm_bridge *bridge,
    32					    enum drm_bridge_attach_flags flags)
    33	{
  > 34		return flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR ? 0 : -EINVAL;
    35	}
    36	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org