linux-kernel - Re: [PATCH 1/2] ima: simplify function ima_store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36c7b81e-ac42-b34a-808b-92107ff85805@linux.microsoft.com>
Date:   Tue, 14 Apr 2020 08:17:14 -0700
From:   Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>
To:     Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>,
        zohar@...ux.ibm.com, dmitry.kasatkin@...il.com, jmorris@...ei.org,
        serge@...lyn.com, zhangliguang@...ux.alibaba.com,
        zhang.jia@...ux.alibaba.com
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ima: simplify function ima_store_template

On 4/14/20 4:48 AM, Tianjia Zhang wrote:

> The 'result' here is not necessary, remove redundant code,
> the code is more concise.
> 
> Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
> ---
>   security/integrity/ima/ima_api.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c
> index f6bc00914aa5..9121257c9dc6 100644
> --- a/security/integrity/ima/ima_api.c
> +++ b/security/integrity/ima/ima_api.c
> @@ -118,8 +118,7 @@ int ima_store_template(struct ima_template_entry *entry,
>   		memcpy(entry->digest, hash.hdr.digest, hash.hdr.length);
>   	}
>   	entry->pcr = pcr;
> -	result = ima_add_template_entry(entry, violation, op, inode, filename);
> -	return result;
> +	return ima_add_template_entry(entry, violation, op, inode, filename);
>   }
>   
>   /*
> 


Reviewed-by: Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>