linux-kernel - Re: [PATCH 0/2] Add SW_MACHINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b13b6bf3-f9e3-1151-81f9-53f3ec9dc26a@wizzup.org>
Date:   Wed, 15 Apr 2020 15:29:32 +0200
From:   Merlijn Wajer <merlijn@...zup.org>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "Darren Hart (VMware)" <dvhart@...radead.org>,
        Mattias Jacobsson <2pi@....nu>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH 0/2] Add SW_MACHINE_COVER key

Hi,

Any objections or further comments on these two patches? It's been a while.

Cheers,
Merlijn

On 15/02/2020 18:02, Merlijn Wajer wrote:
> this series adds the sw_machine_cover key, and changes the nokia n900 dts to
> expose the key via gpio-keys.
> 
> before, this gpio was used as card detect gpio, causing the card not to show up
> if the phone was booted without cover, see this thread on linux-omap:
> 
>     n900: remove mmc1 "safety feature"? (was: re: mmc0 on nokia n900 on linux 5.4.18)
> 
> since there is no realistic use for using this gpio as card detect, instead
> expose it to userspace via gpio-keys. there are no event type for machine covers
> yet, so add that first.
> 
> the key should be 1 when the cover is closed, and 0 when the cover is open.
> 
> starting the nokia n900 with the cover removed, putting the cover in place:
> 
>     event: time 1581684523.415296, type 5 (ev_sw), code 16 (?), value 1
> 
> removing the cover again, exposing mmc1 and the battery:
> 
>     event: time 1581684529.413706, type 5 (ev_sw), code 16 (?), value 0
> 
> Merlijn Wajer (2):
>   Input: add `SW_MACHINE_COVER`
>   ARM: dts: n900: remove mmc1 card detect gpio
> 
>  arch/arm/boot/dts/omap3-n900.dts       | 12 ++++++++----
>  include/linux/mod_devicetable.h        |  2 +-
>  include/uapi/linux/input-event-codes.h |  3 ++-
>  3 files changed, 11 insertions(+), 6 deletions(-)
> 




Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)