linux-kernel - Re: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Apr 2020 11:19:38 +0200
From:   Andreas Färber <afaerber@...e.de>
To:     James Tai [戴志峰] <james.tai@...ltek.com>
Cc:     "linux-realtek-soc@...ts.infradead.org" 
        <linux-realtek-soc@...ts.infradead.org>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1319 and
 Realtek PymParticle EVB

Hi James,

Am 15.04.20 um 10:58 schrieb James Tai [戴志峰]:
>>> diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml
>>> b/Documentation/devicetree/bindings/arm/realtek.yaml
>>> index 845f9c76d6f7..3b48ae71fdd8 100644
>>> --- a/Documentation/devicetree/bindings/arm/realtek.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
>>> @@ -42,6 +42,12 @@ properties:
>>>                  - synology,ds418 # Synology DiskStation DS418
>>>              - const: realtek,rtd1296
>>>
>>> +      # RTD1319 SoC based boards
>>> +      - items:
>>> +          - enum:
>>> +              - realtek,pymparticle # Realtek PymParticle EVB
>>
>> The board seems labelled "PYM_PARTICLES".
>>
>> While Wikipedia has nothing on that, I found this explanation:
>> https://marvel.fandom.com/wiki/Pym_Particles
>>
>> So, are you sure it's PymParticle and not "Pym Particle" with space or "Pym
>> Particles" with space and plural S? The S would affect also the .dts filename.
>>
> I should change the string to "Pym Particles".

Okay, in that case I suggest rtd1319-pymparticles.dts for consistency. 
Unless you want to change rtd1395-lionskin.dts to rtd1395-lion-skin.dts.

>> For the compatible string the question is pymparticle or pym-particle.
>>
> The compatible string is "pym-particles".

Works for me. (always assuming we both imply the "realtek," prefix)

If you send a v4, please double-check the comments in patch 2/2.

>> By comparison, LION-SKIN was named lion-skin in the compatible and spelled
>> Lion Skin in textual form. If you believe that should be fixed, now would be the
>> time to revisit those patches that didn't make v5.7.
>>
> I'll check those relevant patches.

Thanks,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)