[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a9685d4560a6445d81c4919b2a323f68@realtek.com>
Date: Wed, 15 Apr 2020 08:58:09 +0000
From: James Tai [戴志峰] <james.tai@...ltek.com>
To: Andreas Färber <afaerber@...e.de>
CC: "linux-realtek-soc@...ts.infradead.org"
<linux-realtek-soc@...ts.infradead.org>,
Mark Rutland <mark.rutland@....com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Rob Herring <robh+dt@...nel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB
Hi Andreas,
Thanks for your review!
>
> > diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml
> > b/Documentation/devicetree/bindings/arm/realtek.yaml
> > index 845f9c76d6f7..3b48ae71fdd8 100644
> > --- a/Documentation/devicetree/bindings/arm/realtek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
> > @@ -42,6 +42,12 @@ properties:
> > - synology,ds418 # Synology DiskStation DS418
> > - const: realtek,rtd1296
> >
> > + # RTD1319 SoC based boards
> > + - items:
> > + - enum:
> > + - realtek,pymparticle # Realtek PymParticle EVB
>
> The board seems labelled "PYM_PARTICLES".
>
> While Wikipedia has nothing on that, I found this explanation:
> https://marvel.fandom.com/wiki/Pym_Particles
>
> So, are you sure it's PymParticle and not "Pym Particle" with space or "Pym
> Particles" with space and plural S? The S would affect also the .dts filename.
>
I should change the string to "Pym Particles".
> For the compatible string the question is pymparticle or pym-particle.
>
The compatible string is "pym-particles".
> By comparison, LION-SKIN was named lion-skin in the compatible and spelled
> Lion Skin in textual form. If you believe that should be fixed, now would be the
> time to revisit those patches that didn't make v5.7.
>
I'll check those relevant patches.
Thank you.
Regards,
James
Powered by blists - more mailing lists