linux-kernel - Re: [PATCH 3/5] ocfs2: Add missing annotation for dlm_empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200415200201.2efbbbd338a43a2f57988e2d@linux-foundation.org>
Date:   Wed, 15 Apr 2020 20:02:01 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Joseph Qi <joseph.qi@...ux.alibaba.com>
Cc:     Jules Irenge <jbi.octave@...il.com>, linux-kernel@...r.kernel.org,
        boqun.feng@...il.com, Mark Fasheh <mark@...heh.com>,
        Joel Becker <jlbec@...lplan.org>, Gang He <ghe@...e.com>,
        Richard Fontana <rfontana@...hat.com>,
        Allison Randal <allison@...utok.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Aditya Pakki <pakki001@....edu>, ChenGang <cg.chen@...wei.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        "moderated list:ORACLE CLUSTER FILESYSTEM 2 (OCFS2)" 
        <ocfs2-devel@....oracle.com>
Subject: Re: [PATCH 3/5] ocfs2: Add missing annotation for
 dlm_empty_lockres()

On Sat, 4 Apr 2020 07:45:49 +0800 Joseph Qi <joseph.qi@...ux.alibaba.com> wrote:

> On 2020/4/4 00:05, Jules Irenge wrote:
> > Sparse reports a warning at dlm_empty_lockres()
> > 
> > warning: context imbalance in dlm_purge_lockres() - unexpected unlock
> > 
> > The root cause is the missing annotation at dlm_purge_lockres()
> > 
> > Add the missing __must_hold(&dlm->spinlock)
> > 
> Seems this is duplicate with assert_spin_locked()?

I doubt is sparse is smart enough to treat assert_spin_locked() as
equivalent to __must_hold().  It would be neat though.