linux-kernel - Re: [PATCH 3/5] net: macb: fix macb_get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Apr 2020 12:22:24 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     nicolas.ferre@...rochip.com, linux-arm-kernel@...ts.infradead.org,
        netdev@...r.kernel.org,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        harini.katakam@...inx.com
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        pthombar@...ence.com, sergio.prado@...abworks.com,
        antoine.tenart@...tlin.com, linux@...linux.org.uk, andrew@...n.ch,
        michal.simek@...inx.com, Rafal Ozieblo <rafalo@...ence.com>
Subject: Re: [PATCH 3/5] net: macb: fix macb_get/set_wol() when moving to
 phylink



On 4/16/2020 10:44 AM, nicolas.ferre@...rochip.com wrote:
> From: Nicolas Ferre <nicolas.ferre@...rochip.com>
> 
> Keep previous function goals and integrate phylink actions to them.
> 
> phylink_ethtool_get_wol() is not enough to figure out if Ethernet driver
> supports Wake-on-Lan.
> Initialization of "supported" and "wolopts" members is done in phylink
> function, no need to keep them in calling function.
> 
> phylink_ethtool_set_wol() return value is not enough to determine
> if WoL is enabled for the calling Ethernet driver. Call if first
> but don't rely on its return value as most of simple PHY drivers
> don't implement a set_wol() function.
> 
> Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> Cc: Claudiu Beznea <claudiu.beznea@...rochip.com>
> Cc: Harini Katakam <harini.katakam@...inx.com>
> Cc: Rafal Ozieblo <rafalo@...ence.com>
> Cc: Antoine Tenart <antoine.tenart@...tlin.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian