[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <631f9716-bb21-4309-ee6e-ef2594b93a4b@gmail.com>
Date: Thu, 16 Apr 2020 12:21:48 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: nicolas.ferre@...rochip.com, linux-arm-kernel@...ts.infradead.org,
netdev@...r.kernel.org,
Claudiu Beznea <claudiu.beznea@...rochip.com>,
harini.katakam@...inx.com
Cc: linux-kernel@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
pthombar@...ence.com, sergio.prado@...abworks.com,
antoine.tenart@...tlin.com, linux@...linux.org.uk, andrew@...n.ch,
michal.simek@...inx.com, Rafal Ozieblo <rafalo@...ence.com>
Subject: Re: [PATCH 2/5] net: macb: mark device wake capable when
"magic-packet" property present
On 4/16/2020 10:44 AM, nicolas.ferre@...rochip.com wrote:
> From: Nicolas Ferre <nicolas.ferre@...rochip.com>
>
> Change the way the "magic-packet" DT property is handled in the
> macb_probe() function, matching DT binding documentation.
> Now we mark the device as "wakeup capable" instead of calling the
> device_init_wakeup() function that would enable the wakeup source.
>
> For Ethernet WoL, enabling the wakeup_source is done by
> using ethtool and associated macb_set_wol() function that
> already calls device_set_wakeup_enable() for this purpose.
>
> That would reduce power consumption by cutting more clocks if
> "magic-packet" property is set but WoL is not configured by ethtool.
>
> Fixes: 3e2a5e153906 ("net: macb: add wake-on-lan support via magic packet")
> Cc: Claudiu Beznea <claudiu.beznea@...rochip.com>
> Cc: Harini Katakam <harini.katakam@...inx.com>
> Cc: Rafal Ozieblo <rafalo@...ence.com>
> Cc: Sergio Prado <sergio.prado@...abworks.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists