linux-kernel - Re: [PATCH] mfd:asic3:Delete redundant variable definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200416070802.GQ2167633@dell>
Date:   Thu, 16 Apr 2020 08:08:02 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Tang Bin <tangbin@...s.chinamobile.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd:asic3:Delete redundant variable definition

On Fri, 03 Apr 2020, Tang Bin wrote:

> In this function, 'ret' is always assigned, even if 'pdata->leds'
> don't carry out,it has already been assigned a value in the above
> code, including '0',so it's redundant.

Which line initialises/assigns 'ret' before this one?

> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> ---
>  drivers/mfd/asic3.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> index a6bd2134c..cee7454b3 100644
> --- a/drivers/mfd/asic3.c
> +++ b/drivers/mfd/asic3.c
> @@ -924,7 +924,6 @@ static int __init asic3_mfd_probe(struct platform_device *pdev,
>  			goto out;
>  	}
>  
> -	ret = 0;
>  	if (pdata->leds) {
>  		int i;
>  

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog