linux-kernel - Re: [PATCH] mfd:asic3:Delete redundant variable definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <211e7521-639d-804c-f332-bfed0cf315df@cmss.chinamobile.com>
Date:   Thu, 16 Apr 2020 17:57:43 +0800
From:   Tang Bin <tangbin@...s.chinamobile.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd:asic3:Delete redundant variable definition

Hi, Lee:

On 2020/4/16 15:08, Lee Jones wrote:
> On Fri, 03 Apr 2020, Tang Bin wrote:
>
>> In this function, 'ret' is always assigned, even if 'pdata->leds'
>> don't carry out,it has already been assigned a value in the above
>> code, including '0',so it's redundant.
> Which line initialises/assigns 'ret' before this one?

     I think it maybe my fault before, because I treat get resource and 
irq succeed. But now I have two questions  to ask you:

     Q1: About asic3_mfd_probe()?

           In the function asic3_mfd_probe(), if get resource or irq 
failed, the value returned just detected and dev_dbg() error message, 
but there were no error return. What I think the modify should be as 
follows:

     mem_sdio = platform_get_resource(pdev, IORESOURCE_MEM, 1);
     if (!mem_sdio) {
         dev_dbg(asic->dev, "no SDIO MEM resource\n");
         ret = -EINVAL;
         goto out;
     }

     irq = platform_get_irq(pdev, 1);
     if (irq < 0) {
         dev_dbg(asic->dev, "no SDIO IRQ resource\n");
         ret = irq;
         goto out;
     }

     If the function do like this, the 'ret = 0' in line 993 maybe 
redundant.

    Q2: About asic3_probe()?

           In the line 995, if the function asic3_irq_probe() failed, it 
will print error message by the internally called function 
platform_get_irq(), so the dev_err() in the line 997 is redundant, 
should be delete.

     I'll wait actively, and submit the corresponding patch according to 
your reply.

Thanks,

Tang Bin