lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Apr 2020 14:58:51 -0600 From: Mathieu Poirier <mathieu.poirier@...aro.org> To: Markus Elfring <Markus.Elfring@....de> Cc: Suman Anna <s-anna@...com>, linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org, Alex Elder <elder@...aro.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, Ohad Ben-Cohen <ohad@...ery.com> Subject: Re: [v2 5/7] remoteproc: Restructure firmware name allocation Hi Markus, On Fri, Apr 17, 2020 at 05:48:49PM +0200, Markus Elfring wrote: > >> p = firmware ? kstrdup_const(…) : kasprintf(…); > > > > For simple assignments, I too prefer the ternary operator, > > Thanks for your feedback. > > > > but in this case, I think it is better to leave the current code as is. > > Would you like to consider the use of the function “kvasprintf_const” > according to your review comment for the update step “[PATCH v2 4/7] remoteproc: > Use kstrdup_const() rather than kstrup()”? > Looking at the implementation of kvasprintf_const(), using it here wouldn't give us anything. Indeed allocation of duplicate memory is avoided only if the string is pre determined of if it is exactly %s, which isn't the case here. Otherwise things default to kvasprintf(). Thanks, Mathieu > Regards, > Markus
Powered by blists - more mailing lists