linux-kernel - Re: [PATCH] kunit: Add missing newline in summary message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.21.2004171103160.32364@localhost>
Date:   Fri, 17 Apr 2020 11:03:43 +0100 (BST)
From:   Alan Maguire <alan.maguire@...cle.com>
To:     Marco Elver <elver@...gle.com>
cc:     linux-kernel@...r.kernel.org, brendanhiggins@...gle.com,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        alan.maguire@...cle.com, frank.rowand@...y.com,
        skhan@...uxfoundation.org
Subject: Re: [PATCH] kunit: Add missing newline in summary message

On Thu, 16 Apr 2020, Marco Elver wrote:

> Add missing newline, as otherwise flushing of the final summary message
> to the console log can be delayed.
> 
> Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
> Signed-off-by: Marco Elver <elver@...gle.com>

Reviewed-by: Alan Maguire <alan.maguire@...cle.com>

Thanks for finding/fixing this!

Alan

> ---
>  lib/kunit/test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/kunit/test.c b/lib/kunit/test.c
> index 7a6430a7fca0..ccb2ffad8dcf 100644
> --- a/lib/kunit/test.c
> +++ b/lib/kunit/test.c
> @@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,
>  	 * representation.
>  	 */
>  	if (suite)
> -		pr_info("%s %zd - %s",
> +		pr_info("%s %zd - %s\n",
>  			kunit_status_to_string(is_ok),
>  			test_number, description);
>  	else
> -- 
> 2.26.1.301.g55bc3eb7cb9-goog
> 
>