linux-kernel - Re: [PATCH v2] ASoC: bdw-rt5650: remove 3-channel capture support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Apr 2020 08:33:38 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Cezary Rojewski <cezary.rojewski@...el.com>,
        "Lu, Brent" <brent.lu@...el.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Cc:     Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Ben Zhang <benzh@...omium.org>,
        "Chiang, Mac" <mac.chiang@...el.com>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v2] ASoC: bdw-rt5650: remove 3-channel capture support



On 4/17/20 2:59 AM, Cezary Rojewski wrote:
> On 2020-04-17 03:32, Lu, Brent wrote:
>>>
>>> It seems like a generic problem on all Broadwell devices so let's 
>>> solve with
>>> one a single patchset.
>>>
>>> Shouldn't we just add the 2ch constraints for broadwell.c and 
>>> bdw-rt5677.c,
>>> and the 2 or 4ch constraint for bdw-rt5650.c? Would this work for you?
>>>
>>> Thanks
>>> -Pierre
>>
>> Hi Pierre,
>>
>> Are you saying submitting a new patch to add constraints to all three 
>> broadwell.c,
>> bdw-rt5650.c, and bdw-rt5677.c?
>>
>>
>> Regards,
>> Brent
>>
> 
> What Pierre suggested is that you submit a series of patches instead - 
> one for each of BDW machine boards. If the same problem exists on all of 
> them, there is no reason to left other boards unattended.

Yes, a series of 3 patches with the same code pattern, the only 
variation being 4 ch allowed for bdw-rt5650.c in addition to the default 
2ch for all 3 boards.

Thanks
-Pierre