[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200417135624.GA88652@roeck-us.net>
Date: Fri, 17 Apr 2020 06:56:24 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Stephen Boyd <swboyd@...omium.org>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] soc: qcom: cmd-db: Cast sizeof() to int to silence field
width warning
On Tue, Apr 14, 2020 at 11:20:33PM -0700, Stephen Boyd wrote:
> We pass the result of sizeof() here to tell the printk format specifier
> how many bytes to print. That expects an int though and sizeof() isn't
> that type. Cast to int to silence this warning:
>
> drivers/soc/qcom/cmd-db.c: In function 'cmd_db_debugfs_dump':
> drivers/soc/qcom/cmd-db.c:281:30: warning: field width specifier '*' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> ---
> drivers/soc/qcom/cmd-db.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
> index 6c308f92a13c..6b5c440c9dc3 100644
> --- a/drivers/soc/qcom/cmd-db.c
> +++ b/drivers/soc/qcom/cmd-db.c
> @@ -280,7 +280,7 @@ static int cmd_db_debugfs_dump(struct seq_file *seq, void *p)
> ent = rsc_to_entry_header(rsc);
> for (j = 0; j < le16_to_cpu(rsc->cnt); j++, ent++) {
> seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr),
> - sizeof(ent->id), ent->id);
> + (int)sizeof(ent->id), ent->id);
>
> len = le16_to_cpu(ent->len);
> if (len) {
Powered by blists - more mailing lists