linux-kernel - Re: [PATCH] drm/amd/powerplay: remove defined but not used variables

Open Source and information security mailing list archives

Message-ID: <CADnq5_OTQEvOFZ3WaOAGQqMpkcsSkQ2fwge2+YUV59URnwLHgw@mail.gmail.com>
Date:   Fri, 17 Apr 2020 09:58:03 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     "Quan, Evan" <evan.quan@....com>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] drm/amd/powerplay: remove defined but not used variables

On Fri, Apr 17, 2020 at 9:16 AM Jason Yan <yanaijie@...wei.com> wrote:
>
> Fix the following gcc warning:
>
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:710:46:
> warning: ‘PSMGCEDCThresholdConfig_vega10’ defined but not used
> [-Wunused-const-variable=]
>  static const struct vega10_didt_config_reg
> PSMGCEDCThresholdConfig_vega10[] =
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:654:46:
> warning: ‘PSMSEEDCThresholdConfig_Vega10’ defined but not used
> [-Wunused-const-variable=]
>  static const struct vega10_didt_config_reg
> PSMSEEDCThresholdConfig_Vega10[] =
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

Applied.  Thanks!

Alex

> ---
>  .../amd/powerplay/hwmgr/vega10_powertune.c    | 23 -------------------
>  1 file changed, 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> index ca9b23b5abc9..9757d47dd6b8 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> @@ -651,18 +651,6 @@ static const struct vega10_didt_config_reg   PSMSEEDCStallDelayConfig_Vega10[] =
>         {   0xFFFFFFFF  }  /* End of list */
>  };
>
> -static const struct vega10_didt_config_reg   PSMSEEDCThresholdConfig_Vega10[] =
> -{
> -/* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - *      Offset                             Mask                                                 Shift                                                  Value
> - * ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - */
> -       /* SQ EDC THRESHOLD */
> -       {   ixDIDT_SQ_EDC_THRESHOLD,           DIDT_SQ_EDC_THRESHOLD__EDC_THRESHOLD_MASK,           DIDT_SQ_EDC_THRESHOLD__EDC_THRESHOLD__SHIFT,            0x0000 },
> -
> -       {   0xFFFFFFFF  }  /* End of list */
> -};
> -
>  static const struct vega10_didt_config_reg   PSMSEEDCCtrlResetConfig_Vega10[] =
>  {
>  /* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> @@ -707,17 +695,6 @@ static const struct vega10_didt_config_reg   PSMSEEDCCtrlConfig_Vega10[] =
>         {   0xFFFFFFFF  }  /* End of list */
>  };
>
> -static const struct vega10_didt_config_reg   PSMGCEDCThresholdConfig_vega10[] =
> -{
> -/* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - *      Offset                             Mask                                                 Shift                                                  Value
> - * ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - */
> -       {   mmGC_EDC_THRESHOLD,                GC_EDC_THRESHOLD__EDC_THRESHOLD_MASK,                GC_EDC_THRESHOLD__EDC_THRESHOLD__SHIFT,                 0x0000000 },
> -
> -       {   0xFFFFFFFF  }  /* End of list */
> -};
> -
>  static const struct vega10_didt_config_reg   PSMGCEDCDroopCtrlConfig_vega10[] =
>  {
>  /* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> --
> 2.21.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives