linux-kernel - RE: [PATCH v5 4/5] scsi: ufs-exynos: add UFS host support for Exynos SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Apr 2020 23:21:31 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Christoph Hellwig'" <hch@...radead.org>
Cc:     <robh@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-scsi@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>,
        <martin.petersen@...cle.com>, <linux-kernel@...r.kernel.org>,
        <krzk@...nel.org>, <kwmad.kim@...sung.com>, <avri.altman@....com>,
        <cang@...eaurora.org>, "'Seungwon Jeon'" <essuuj@...il.com>,
        <stanley.chu@...iatek.com>, <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v5 4/5] scsi: ufs-exynos: add UFS host support for
 Exynos SoCs

Hi Christoph,
Thanks for your feedback.

> -----Original Message-----
> From: 'Christoph Hellwig' <hch@...radead.org>
> Sent: 13 April 2020 19:09
> To: Alim Akhtar <alim.akhtar@...sung.com>
> Cc: 'Christoph Hellwig' <hch@...radead.org>; robh@...nel.org;
> devicetree@...r.kernel.org; linux-scsi@...r.kernel.org; linux-samsung-
> soc@...r.kernel.org; martin.petersen@...cle.com; linux-
> kernel@...r.kernel.org; krzk@...nel.org; kwmad.kim@...sung.com;
> avri.altman@....com; cang@...eaurora.org; 'Seungwon Jeon'
> <essuuj@...il.com>; stanley.chu@...iatek.com; linux-arm-
> kernel@...ts.infradead.org
> Subject: Re: [PATCH v5 4/5] scsi: ufs-exynos: add UFS host support for
Exynos
> SoCs
> 
> On Sun, Apr 12, 2020 at 09:54:53PM +0530, Alim Akhtar wrote:
> > > So this doesn't actually require the various removed or not added
> > > quirks
> > after
> > > all?
> > This driver is actual consumer of those quirks, so those are still
needed.
> > On Martin's 5.7/scsi-queue need to revert " 492001990f64 scsi: ufshcd:
> > remove unused quirks"
> 
> No. You need to include one patch per quirk in your series to add them
back.
Sure, will send the updated version soon.

> Please also follow all proper kernel style guidelines, as the old code
didn't
> always follow the proper style.