linux-kernel - RE: [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <002a01d61582$72250990$566f1cb0$@samsung.com>
Date:   Sat, 18 Apr 2020 18:38:21 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Avri Altman'" <Avri.Altman@....com>, <robh@...nel.org>
Cc:     <devicetree@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <krzk@...nel.org>, <martin.petersen@...cle.com>,
        <kwmad.kim@...sung.com>, <stanley.chu@...iatek.com>,
        <cang@...eaurora.org>, <linux-samsung-soc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI

Hi Avri,

> -----Original Message-----
> From: Avri Altman <Avri.Altman@....com>
> Sent: 18 April 2020 18:09
> To: Alim Akhtar <alim.akhtar@...sung.com>; robh@...nel.org
> Cc: devicetree@...r.kernel.org; linux-scsi@...r.kernel.org; krzk@...nel.org;
> martin.petersen@...cle.com; kwmad.kim@...sung.com;
> stanley.chu@...iatek.com; cang@...eaurora.org; linux-samsung-
> soc@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org
> Subject: RE: [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI
> 
> 
> >
> > This patch-set introduces UFS (Universal Flash Storage) host
> > controller support for Samsung family SoC. Mostly, it consists of UFS
> > PHY and host specific driver.
> >
> > - Changes since v5:
> > * re-introduce various quicks which was removed because of no driver
> > * consumer of those quirks, initial 4 patches does the same.
> You forgot to add those quirks to ufs_fixups.

ufs_fixups are for ufs __device__ related quirks, what I have posted are all host controller quirks.
Please have a look on the other quirks related to HCI like UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION
Which is used in other vendor HCI driver. 
Let me know if I am missing anything here.

> Each patch that introduces a quirk needs to introduce its users as well - This is
> the reason it was removed in the first place.
> 
> Thanks,
> Avri