linux-kernel - Re: [PATCH 4/4] test_kmod: Avoid potential double free in trigger_config_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <53bf9145-db17-9123-2489-540eaf2733a6@web.de>
Date:   Sat, 18 Apr 2020 19:23:07 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>,
        linux-kselftest@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH 4/4] test_kmod: Avoid potential double free in
 trigger_config_run_type()

> It should set config->test_fs instead of config->test_driver as NULL
> after kfree_const(config->test_fs) to avoid potential double free.

I suggest to improve this change description.

* How do you think about a wording variant like the following?

  Reset the member “test_fs” of the test configuration after a call
  of the function “kfree_const” to a null pointer so that a double
  memory release will not be performed.

* Would you like to add the tag “Fixes”?

Regards,
Markus