linux-kernel - Re: [PATCH 4/4] test_kmod: Avoid potential double free in trigger_config_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a917be73-202b-8e38-6039-cccda3e59a5f@loongson.cn>
Date:   Mon, 20 Apr 2020 09:07:13 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Markus Elfring <Markus.Elfring@....de>,
        linux-kselftest@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 4/4] test_kmod: Avoid potential double free in
 trigger_config_run_type()

On 04/19/2020 01:23 AM, Markus Elfring wrote:
>> It should set config->test_fs instead of config->test_driver as NULL
>> after kfree_const(config->test_fs) to avoid potential double free.
> I suggest to improve this change description.
>
> * How do you think about a wording variant like the following?
>
>    Reset the member “test_fs” of the test configuration after a call
>    of the function “kfree_const” to a null pointer so that a double
>    memory release will not be performed.
>
> * Would you like to add the tag “Fixes”?
>
> Regards,
> Markus

OK, I will send a v2 patch with the updated commit message and "Fixes" tag.

Thanks,
Tiezhu Yang