[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200418191338.GR5820@bombadil.infradead.org>
Date: Sat, 18 Apr 2020 12:13:38 -0700
From: Matthew Wilcox <willy@...radead.org>
To: Joe Perches <joe@...ches.com>
Cc: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Alexander Viro <viro@...iv.linux.org.uk>,
linux-fsdevel@...r.kernel.org,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
linux-input@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org,
"J. Bruce Fields" <bfields@...ldses.org>,
Chuck Lever <chuck.lever@...cle.com>,
linux-nfs@...r.kernel.org,
Johannes Berg <johannes@...solutions.net>,
Dan Williams <dan.j.williams@...el.com>,
Vishal Verma <vishal.l.verma@...el.com>,
Dave Jiang <dave.jiang@...el.com>, linux-nvdimm@...ts.01.org,
"Martin K. Petersen" <martin.petersen@...cle.com>,
linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
Zzy Wysm <zzy@...wysm.com>
Subject: Re: [PATCH 7/9] drivers/base: fix empty-body warnings in
devcoredump.c
On Sat, Apr 18, 2020 at 11:55:05AM -0700, Joe Perches wrote:
> On Sat, 2020-04-18 at 11:53 -0700, Randy Dunlap wrote:
> > On 4/18/20 11:50 AM, Matthew Wilcox wrote:
> > > On Sat, Apr 18, 2020 at 11:41:09AM -0700, Randy Dunlap wrote:
> > > > @@ -294,11 +295,11 @@ void dev_coredumpm(struct device *dev, s
> > > >
> > > > if (sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj,
> > > > "failing_device"))
> > > > - /* nothing - symlink will be missing */;
> > > > + do_empty(); /* nothing - symlink will be missing */
> > > >
> > > > if (sysfs_create_link(&dev->kobj, &devcd->devcd_dev.kobj,
> > > > "devcoredump"))
> > > > - /* nothing - symlink will be missing */;
> > > > + do_empty(); /* nothing - symlink will be missing */
> > > >
> > > > INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
> > > > schedule_delayed_work(&devcd->del_wk, DEVCD_TIMEOUT);
> > >
> > > Could just remove the 'if's?
> > >
> > > + sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj,
> > > + "failing_device");
> > >
> >
> > OK.
>
> sysfs_create_link is __must_check
Oh, I missed the declaration -- I just saw the definition. This is a
situation where __must_check hurts us and it should be removed.
Or this code is wrong and it should be
WARN(sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj,
"failing_device");
like drivers/pci/controller/vmd.c and drivers/i2c/i2c-mux.c
Either way, the do_empty() construct feels like the wrong way of covering
up the warning.
Powered by blists - more mailing lists