[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK8P3a0-7mLhGb=LCAQSTL4kNoGVcBcQOca=-tJkZAj1w2Bxsg@mail.gmail.com>
Date: Sat, 18 Apr 2020 21:11:06 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Wang Wenhu <wenhu.wang@...o.com>
Cc: gregkh <gregkh@...uxfoundation.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Scott Wood <oss@...error.net>,
christophe leroy <christophe.leroy@....fr>,
linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, kernel@...o.com,
Randy Dunlap <rdunlap@...radead.org>,
Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH v6,4/4] drivers: misc: new driver sram_uapi for user level
SRAM access
On Sat, Apr 18, 2020 at 6:22 PM Wang Wenhu <wenhu.wang@...o.com> wrote:
> +#define DRIVER_NAME "sram_uapi"
> +
> +#define SRAM_UAPI_IOCTL_SET_SRAM_TYPE 0
> +#define SRAM_UAPI_IOCTL_ALLOC 1
> +#define SRAM_UAPI_IOCTL_FREE 2
> +
> +struct res_info {
> + u32 offset;
> + u32 size;
> +};
This is of course not a proper ioctl interface at all, please see
Documentation/driver-api/ioctl.rst for how to define the numbers
in a uapi header file.
The offset/size arguments should probably be 64 bit wide.
Arnd
Powered by blists - more mailing lists