linux-kernel - [PATCH] drivers/char/hw_random/cctrng.c: Compilation fix.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 Apr 2020 15:21:18 +0530
From:   jagdsh.linux@...il.com
To:     hadar.gat@....com, mpm@...enic.com, herbert@...dor.apana.org.au,
        arnd@...db.de, gregkh@...uxfoundation.org
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jagadeesh Pagadala <jagdsh.linux@...il.com>
Subject: [PATCH] drivers/char/hw_random/cctrng.c: Compilation fix.

From: Jagadeesh Pagadala <jagdsh.linux@...il.com>

Adding the needed header <linux/fips.h> to fix following compilation error.

	CC      drivers/char/hw_random/cctrng.o
	drivers/char/hw_random/cctrng.c: In function ‘cc_trng_compwork_handler’:
	drivers/char/hw_random/cctrng.c:334:49: error: ‘fips_enabled’ undeclared (first use in this function)
	  if (CC_REG_FLD_GET(RNG_ISR, CRNGT_ERR, isr) && fips_enabled) {
							 ^
	drivers/char/hw_random/cctrng.c:334:49: note: each undeclared identifier is reported only once for each function it appears in
	drivers/char/hw_random/cctrng.c:335:3: error: implicit declaration of function ‘fips_fail_notify’ [-Werror=implicit-function-declaration]
	   fips_fail_notify();
	   ^
	cc1: some warnings being treated as errors
	make[4]: *** [drivers/char/hw_random/cctrng.o] Error 1

Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@...il.com>
---
 drivers/char/hw_random/cctrng.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/char/hw_random/cctrng.c b/drivers/char/hw_random/cctrng.c
index bdcd562..3124269 100644
--- a/drivers/char/hw_random/cctrng.c
+++ b/drivers/char/hw_random/cctrng.c
@@ -18,6 +18,10 @@
 
 #include "cctrng.h"
 
+#ifdef CONFIG_CRYPTO_FIPS
+#include <linux/fips.h>
+#endif
+
 #define CC_REG_LOW(name)  (name ## _BIT_SHIFT)
 #define CC_REG_HIGH(name) (CC_REG_LOW(name) + name ## _BIT_SIZE - 1)
 #define CC_GENMASK(name)  GENMASK(CC_REG_HIGH(name), CC_REG_LOW(name))
-- 
1.8.3.1